Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show generic error messages when server returns no response #1056

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

mlambley
Copy link
Contributor

No description provided.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ezimuel
Copy link
Contributor

ezimuel commented Oct 5, 2020

Thanks @mlambley for this PR and sorry for the delay. I only changed the $exception as Exception instead of ElasticsearchException in Connection::convertBodyToString function. This is required by static code analysis since the ElasticsearchException interface is empty and we used getMessage() as part of the Throwable interface.

@ezimuel ezimuel added this to the 7.9.1 milestone Oct 5, 2020
@mlambley mlambley deleted the null-error-messages-7x branch October 5, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants