Remove unnecessary InvalidArgumentExceptions #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some locations where an object is type hinted and inside the method a check is performed to verify the type again. This is not necessary as PHP will take care of this. A consequence of this is that these methods no longer throw an instance of `\Elasticsearch\Common\Exceptions\InvalidArgumentException` but of `\InvalidArgumentException`. As theres no PHPDoc indicating that the aforementioned exception is thrown by these methods I dont see any issues with this.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@timoschinkel thanks for the PR! Yes, there are some part of the code to be modified since we introduced type hint. If you find other issue please send other PRs. Thanks again. |
|
Sorry @timoschinkel I just noticed that you sent the PR to |
ezimuel
pushed a commit
that referenced
this pull request
Dec 16, 2020
There are some locations where an object is type hinted and inside the method a check is performed to verify the type again. This is not necessary as PHP will take care of this. A consequence of this is that these methods no longer throw an instance of `\Elasticsearch\Common\Exceptions\InvalidArgumentException` but of `\InvalidArgumentException`. As theres no PHPDoc indicating that the aforementioned exception is thrown by these methods I dont see any issues with this.
timoschinkel
deleted the
remove-unnecessary-invalid-argument-exceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some locations where an object is type hinted and inside the method a check is performed to verify the type again. This is not necessary as PHP will take care of this. A consequence of this is that these methods no longer throw an instance of
\Elasticsearch\Common\Exceptions\InvalidArgumentExceptionbut of\InvalidArgumentException. As theres no PHPDoc indicating that the aforementioned exception is thrown by these methods I don't see any issues with this.I've been working with this library for a little while now and I notice discrepancies in type hints and docblocks. All of the public methods in
\Elasticsearch\Clientcan throw exceptions, but this is not reflected in the docblocks. I did not want to make a large pull request with a lot of changes as it is an unsolicited pull request. Would you be interested in some pull requests to try and straighten that?