Add the x-elastic-client-meta header #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
suggested changes
Dec 15, 2020
| private function getElasticMetaHeader(array $connectionParams): string | ||
| { | ||
| $clientMeta = sprintf( | ||
| "es=%s,php=%s,a=%d", |
There was a problem hiding this comment.
Need to add t=... for PHP transport version is the same as client version I assume?
should be: x-elastic-client-meta: es=7.10.0,php=7.4.11,t=7.10.0,a=0,c=7.68.0 in the end
There was a problem hiding this comment.
I didn't insert the transport t parameter because I read this in the specification: "If there is no transport library separate from the client library then the key must be omitted".
There was a problem hiding this comment.
I added the t parameter since the spec was outdated.
sethmlarson
approved these changes
Dec 16, 2020
ezimuel
added a commit
that referenced
this pull request
Dec 16, 2020
* Replaced array_walk with array_map In Connection::getURI, array_walk was used together with passing the values as references, to change the original array. Passing values as references is error-prone and discouraged for quite some time. Also, when using in conjunction with PHP 8.0, it will fail. array_map can do the same thing as the original array_walk implementation, but without the downsides of having side effects and having to pass values as references. * Add the x-elastic-client-meta header (#1089) * Added the x-elastic-client-meta header * Removed @ExpectedException usage in PHPUnit * Removed prestissimo plugin for composer in github action * Added .phpunit.result.cache in .gitignore * Add the t transport parameter in telemetry client header * Fixed semver format for PHP version in client telemetry header Co-authored-by: Enrico Zimuel <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
x-elastic-client-metaheader in the HTTP request to send version information about the PHP language, the client library, the cURL version, the usage of async, etc.An example of
x-elastic-client-metais as follows:where
esis Elasticsearch version,phpis PHP version,a=0means the HTTP call was sync (1=async),cis the cURL version.This header can be disabled using the function
ClientBuilder::setElasticMetaHeader(false), as follows: