Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds Helpers section to PHP book #1129

Merged
merged 3 commits into from
May 12, 2021
Merged

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 22, 2021

Overview

This PR adds a new section to the PHP book called Client helpers. It contains the following:

  • Iterators
    • Search response iterator
    • Search hit iterator

It also moves:

  • Dealing with JSON arrays and objects in PHP section under Configuration,
  • Community and Breaking changes sections under Overview.

This PR is part of the Client docs redesign effort. Related issue: https://github.com/elastic/clients-team/issues/257

Preview

Client helpers

@szabosteve
Copy link
Contributor Author

@elasticmachine test this please

Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ezimuel ezimuel merged commit 8ca8b62 into elastic:master May 12, 2021
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request May 12, 2021
* [DOCS] Adds Helpers section to PHP book.

* [DOCS] Changes attribute to absolute link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants