Fix #1176 adding includePortInHostHeader in fromConfig #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2021
technige
reviewed
Dec 7, 2021
src/Elasticsearch/ClientBuilder.php
Outdated
| @@ -197,7 +197,8 @@ public static function fromConfig(array $config, bool $quiet = false): Client | |||
| { | |||
| $builder = new static; | |||
| foreach ($config as $key => $value) { | |||
| $method = "set$key"; | |||
| $allowedMethods = ['includePortInHostHeader']; // other available methods | |||
There was a problem hiding this comment.
Might it be better to move this hard-coded list of allowed methods up to class scope? It would be potentially easier to find there, and wouldn't get created for each loop iteration.
There was a problem hiding this comment.
Good suggestion, I'll move it using a class constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1176 adding includePortInHostHeader support in ClientBuilder::fromConfig.