Added PHP 8.4 Support for Elasticsearch 6.8.x #1420
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
Sorry it was not clear to me at first how I was to sign the CLA, and after clicking the initial button nothing really happened, so I assumed some cookies-related magic and posted the PR... 😳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes in line with #1417 to add PHP 8.4 support to the 6.8.x branch.
It fixes a common problem with implicitly nullable parameters being deprecated in PHP 8.4.
The changes are backwards compatible till PHP 7.1 and should be good to go.
Thank you in advance!