Fixing script get and delete by removing lang from endpoint url #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? |
|
I think that lang was copied from putScript. You should replace the doc in your commit. |
|
I updated the PR to include the asciidoc change, updated the function comments in Client.php, and also removed the unused extract lang argument for put script. Please let me know if you have other feedback. Thanks! |
|
I create an issue #824 |
|
deleteScript() breaks in ES 6.4. Can this be integrated sooner? |
|
@polyfractal That would be useful |
|
@polyfractal very useful to have this |
|
@polyfractal any chance you can merge this soon? |
|
Hi @feydan, @idr0id, @polyfractal and more. I'm the new maintainer of this library. I'll merge this PR soon. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.