Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate arguments in documentation #1169

Merged
merged 3 commits into from
Mar 20, 2020

Conversation

mortenhauberg
Copy link

As agreed in #1163

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sethmlarson
Copy link
Contributor

Change looks good, can you commit the changes that would be applied to elasticsearch/client as well :)

@mortenhauberg
Copy link
Author

Yes - just need to figure out why I see extra spaces in the generated code

@sethmlarson
Copy link
Contributor

sethmlarson commented Mar 20, 2020

Maybe you need to update your local 7.x branch? You could try hitting the "Update branch" in GitHub and then doing a git pull origin dedupe-arguments locally.

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks great! Thank you very much 🚀🎉

@mortenhauberg
Copy link
Author

I think that was it, @sethmlarson.

Thank you very much for your help

@sethmlarson sethmlarson merged commit acbbdd2 into elastic:7.x Mar 20, 2020
@sethmlarson
Copy link
Contributor

@mortenhauberg Any time! ❤️ I'll give you a mention the next time we release :) If you find any other issues you want to work on I'll be sure to give guidance as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants