Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid generating unneeded #[serde(rename)] #134

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Avoid generating unneeded #[serde(rename)] #134

merged 2 commits into from
Aug 31, 2020

Conversation

swallez
Copy link
Member

@swallez swallez commented Aug 31, 2020

Avoid generating #[serde(rename)] for fields that have not been renamed.

Drive-by changes:

  • add IntelliJ iml files to .gitignore
  • comment out rustfmt attributes that aren't stable yet

swallez added 2 commits August 31, 2020 10:55
@swallez
Do not generate unneded #[serde(rename)]
403bade 
Avoid generating #[serde(rename)] for fields that have not been renamed.

Drive-by changes:
- add IntelliJ iml files to .gitignore
- comment out rustfmt attributes that aren't stable yet
@swallez
Generated code produced by previous commit
459bd45
@swallez swallez requested a review from russcam August 31, 2020 08:59
@swallez swallez self-assigned this Aug 31, 2020
russcam
russcam approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much tidier! 👍

This can be ported to 7.x and 7.9 branches. The api generator may need to be run on each of those branches if changes don't port cleanly; I think there may be some differences in supported params across branches to contend with

@swallez swallez merged commit 6ee563b into elastic:master Aug 31, 2020
@swallez swallez deleted the reduce_serde_rename branch August 31, 2020 11:24
@swallez swallez changed the title Avoid generating unneded #[serde(rename)] Avoid generating unneeded #[serde(rename)] Aug 31, 2020
russcam pushed a commit that referenced this pull request Sep 2, 2020
@swallez @russcam
Do not generate unneeded #[serde(rename)] (#134)
404a8b2 
(cherry picked from commit 6ee563b)
russcam pushed a commit that referenced this pull request Sep 2, 2020
@swallez @russcam
Do not generate unneeded #[serde(rename)] (#134)
e6715c0 
(cherry picked from commit 6ee563b)
@swallez swallez added enhancement New feature or request v7.10.0-alpha.1 labels Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam approved these changes

Assignees

@swallez swallez

Labels
enhancement New feature or request v7.10.0-alpha.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swallez @russcam