Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README doctests on latest nightly (#175) #176

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Fix README doctests on latest nightly (#175) #176

merged 1 commit into from
Jun 18, 2021

Conversation

nathanregner
Copy link
Contributor

@nathanregner nathanregner commented Jun 10, 2021

doc(include) was removed in rust-lang/rust#85457.
Tests should now run on on both nightly and stable.

Fixes #175

doc(include) was removed in rust-lang/rust#85457.
Tests should now run on on both nightly and stable.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 10, 2021

💚 CLA has been signed

@krojew
Copy link
Contributor

krojew commented Jun 17, 2021

@nathanregner if you don't want to sign the agreement, I can submit the change on your behalf. What do you think?

@russcam russcam merged commit d96bfa2 into elastic:master Jun 18, 2021
@russcam
Copy link
Contributor

russcam commented Jun 18, 2021

Thanks @nathanregner 👍

russcam pushed a commit that referenced this pull request Jun 18, 2021
doc(include) was removed in rust-lang/rust#85457.
Tests should now run on on both nightly and stable.

(cherry picked from commit d96bfa2)
@krojew
Copy link
Contributor

krojew commented Jun 29, 2021

@russcam will there be a release with this change? Right now, it's impossible to use the released crate on nightly.

@russcam
Copy link
Contributor

russcam commented Jun 29, 2021

Thanks for the prompt, @krojew. We'll look to get a new release out shortly

@russcam russcam added bug Something isn't working v7.12.1-alpha.1 labels Jun 29, 2021
@russcam
Copy link
Contributor

russcam commented Jun 29, 2021

@krojew new version, 7.12.1-alpha.1 is now on crates.io

russcam pushed a commit that referenced this pull request Jun 29, 2021
doc(include) was removed in rust-lang/rust#85457.
Tests should now run on on both nightly and stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v7.12.1-alpha.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Build fails on latest nightly
4 participants