Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exception mangling around LoggingTaskListener #102369

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Remove exception mangling around LoggingTaskListener #102369

merged 1 commit into from
Nov 20, 2023
+8 −9

Conversation

DaveCTurner
Copy link
Contributor

Replaces ListenableActionFuture with SubscribableListener at both
call sites.

@DaveCTurner
Remove exception mangling around LoggingTaskListener
e65c4e0 
Replaces `ListenableActionFuture` with `SubscribableListener` at both
call sites.
@DaveCTurner DaveCTurner added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >refactoring v8.12.0 labels Nov 20, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 20, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner DaveCTurner requested a review from arteam November 20, 2023 11:15
arteam
arteam approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks David

@DaveCTurner DaveCTurner merged commit 36a2f9b into elastic:main Nov 20, 2023
13 checks passed
@DaveCTurner DaveCTurner deleted the 2023/11/20/LoggingTaskListener-exception-mangling branch November 20, 2023 18:44
@DaveCTurner DaveCTurner restored the 2023/11/20/LoggingTaskListener-exception-mangling branch June 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arteam arteam arteam approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >refactoring Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @arteam