-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing remote_cluster docs #116366
Fix missing remote_cluster docs #116366
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Left only a non-blocking question if we should update the example role to include remote_cluster
.
@@ -80,7 +81,7 @@ POST /_security/role/remote-search | |||
"privileges": [ | |||
"read", | |||
"read_cross_cluster", | |||
"view_index_metadata" | |||
"view_index_metadata" | |||
] | |||
} | |||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should update example remote-search
role to include remote cluster privileges?
] | |
], | |
"remote_cluster": [ | |
{ | |
"privileges": [ | |
"monitor_enrich" | |
], | |
"clusters": [ | |
"my_remote_cluster" | |
] | |
} | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet. This PR backfills some missing docs and will target elder docs where monitor_enrich
is the privilege allowed (that usage is already covered in ES|QL docs where it is relevant). I will have another docs PR to introduce a new remote_cluster privilege and will consider it then.
@@ -75,7 +75,7 @@ that begin with `_` are reserved for system usage. | |||
For more information, see | |||
<<run-as-privilege>>. | |||
|
|||
`remote_indices`:: beta:[] (list) A list of remote indices permissions entries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Documentation for the remote_cluster in the role was added in elastic#111682 and elastic#108840, but a few places were missed. This commit fill the gaps in the documentation.
Documentation for the remote_cluster in the role was added in elastic#111682 and elastic#108840, but a few places were missed. This commit fill the gaps in the documentation.
Documentation for the remote_cluster in the role was added
in #111682 and #108840, but a few places were missed.
This commit fill the gaps in the documentation.