-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split searchable snapshot into multiple repo operations #116918
Merged
elasticsearchmachine
merged 10 commits into
elastic:main
from
DaveCTurner:2024/11/17/mutable-searchable-snapshot-repository
Nov 18, 2024
Merged
Split searchable snapshot into multiple repo operations #116918
elasticsearchmachine
merged 10 commits into
elastic:main
from
DaveCTurner:2024/11/17/mutable-searchable-snapshot-repository
Nov 18, 2024
Commits on Nov 18, 2024
-
Split searchable snapshot into multiple repo operations
Each operation on a snapshot repository uses the same `Repository`, `BlobStore`, etc. instances throughout, in order to avoid the complexity arising from handling metadata updates that occur while an operation is running. Today we model the entire lifetime of a searchable snapshot shard as a single repository operation since there should be no metadata updates that matter in this context (other than those that are handled dynamically via other mechanisms) and some metadata updates might be positively harmful to a searchable snapshot shard. It turns out that there are some undocumented legacy settings which _do_ matter to searchable snapshots, and which are still in use, so with this commit we move to a finer-grained model of repository operations within a searchable snapshot.
Configuration menu - View commit details
-
Copy full SHA for cef1b54 - Browse repository at this point
Copy the full SHA cef1b54View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1b19cf - Browse repository at this point
Copy the full SHA a1b19cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 333511a - Browse repository at this point
Copy the full SHA 333511aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a31dcf - Browse repository at this point
Copy the full SHA 8a31dcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e326a48 - Browse repository at this point
Copy the full SHA e326a48View commit details -
Configuration menu - View commit details
-
Copy full SHA for f12848a - Browse repository at this point
Copy the full SHA f12848aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8e7eb - Browse repository at this point
Copy the full SHA 3a8e7ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for df424fa - Browse repository at this point
Copy the full SHA df424faView commit details -
Configuration menu - View commit details
-
Copy full SHA for a547e2c - Browse repository at this point
Copy the full SHA a547e2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4473e75 - Browse repository at this point
Copy the full SHA 4473e75View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.