Remove InvalidShapeException from GeoPolygonDecomposer #77613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
:Analytics/Geo
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
iverase
commented
Sep 13, 2021
| @@ -834,9 +834,6 @@ public void testInvalidSelfCrossingPolygon() { | |||
| Exception e = expectThrows(InvalidShapeException.class, () -> builder.close().buildS4J()); | |||
| assertThat(e.getMessage(), containsString("Self-intersection at or near point [")); | |||
| assertThat(e.getMessage(), not(containsString("NaN"))); | |||
| e = expectThrows(InvalidShapeException.class, () -> buildGeometry(builder.close())); | |||
| assertThat(e.getMessage(), containsString("Self-intersection at or near point [")); | |||
| assertThat(e.getMessage(), not(containsString("NaN"))); | |||
There was a problem hiding this comment.
This is already tested in GeometryIndexerTests
|
I change this PR to be a bug fix as it fixes an issue with `ignore_malformed' setting. |
iverase
added
v7.15.1
auto-backport-and-merge
auto-backport
This was referenced Sep 15, 2021
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Sep 15, 2021
fixes a bug where InvalidShapeException are not properly handle so even if the mappings defined with ignore_malformed set to true, the exception leaks and the setting is ignored
iverase
added a commit
that referenced
this pull request
Sep 15, 2021
iverase
added a commit
that referenced
this pull request
Sep 15, 2021
#77740) fixes a bug where InvalidShapeException are not properly handle so even if the mappings defined with ignore_malformed set to true, the exception leaks and the setting is ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidShapeException comes from Spatial4j dependency and should not be part of GeoPolygonDecomposer. Let's replace this exception with an IllegalArgumentException.
The change actually fixes a bug where InvalidShapeException are not properly handle so even if the mappings defined with
ignore_malformedset to true, the exception leaks and the setting is ignored. Changing to IllegalArgumentException makes it behave properly.fixes #77685
fixes #75753