-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Jackson xml to 2.15.0 #95641
Conversation
Additionally this commit updates snakeyaml to 2.0 as that is the version now used by Jackson.
Hi @rjernst, I've created a changelog YAML for you. |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise LGTM.
@@ -10,7 +10,7 @@ apply plugin: 'elasticsearch.java' | |||
|
|||
archivesBaseName = "x-content-impl" | |||
|
|||
String jacksonVersion = "2.14.2" | |||
String jacksonVersion = "2.15.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't just use what's in version.properties
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we want x-content to be independent because we have had situations where we want to update this more quickly. I don't think we should have jackson in version.properties anymore at all, but it's been difficult to get momentum to remove it from there.
💚 Backport successful
|
Additionally this commit updates snakeyaml to 2.0 as that is the version now used by Jackson.
any reason this commit wasn't ported to 7.17? |
@rjernst any reason this commit wasn't ported to 7.17? |
Additionally this commit updates snakeyaml to 2.0 as that is the version now used by Jackson.