Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jackson xml to 2.15.0 #95641

Merged
merged 4 commits into from
May 2, 2023
Merged

Upgrade Jackson xml to 2.15.0 #95641

merged 4 commits into from
May 2, 2023

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Apr 27, 2023

Additionally this commit updates snakeyaml to 2.0 as that is the version now used by Jackson.

Additionally this commit updates snakeyaml to 2.0 as that is the version
now used by Jackson.
@elasticsearchmachine
Copy link
Collaborator

Hi @rjernst, I've created a changelog YAML for you.

@rjernst rjernst marked this pull request as ready for review April 27, 2023 19:34
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Apr 27, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst requested a review from mark-vieira May 2, 2023 18:12
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM.

@@ -10,7 +10,7 @@ apply plugin: 'elasticsearch.java'

archivesBaseName = "x-content-impl"

String jacksonVersion = "2.14.2"
String jacksonVersion = "2.15.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we don't just use what's in version.properties here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we want x-content to be independent because we have had situations where we want to update this more quickly. I don't think we should have jackson in version.properties anymore at all, but it's been difficult to get momentum to remove it from there.

@rjernst rjernst merged commit 8b8a2be into elastic:main May 2, 2023
@rjernst rjernst deleted the jackson/upgrade branch May 2, 2023 20:59
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.8

rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 2, 2023
Additionally this commit updates snakeyaml to 2.0 as that is the version
now used by Jackson.
elasticsearchmachine pushed a commit that referenced this pull request May 2, 2023
Additionally this commit updates snakeyaml to 2.0 as that is the version
now used by Jackson.
@lnayer
Copy link

lnayer commented Jul 17, 2023

any reason this commit wasn't ported to 7.17?

@lnayer
Copy link

lnayer commented Jul 25, 2023

@rjernst any reason this commit wasn't ported to 7.17?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >upgrade v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants