[6.8] Upgrade from Node.js 10 to 12

.node-version

@@ -1 +1 @@
-10.24.1
+12.22.1

.nvmrc

@@ -1 +1 @@
-10.24.1
+12.22.1

bin/kibana

@@ -21,4 +21,4 @@ if [ ! -x "$NODE" ]; then
   exit 1
 fi
 
-NODE_ENV=production exec "${NODE}" --no-warnings --max-http-header-size=65536 $NODE_OPTIONS "${DIR}/src/cli" ${@}
+NODE_ENV=production exec "${NODE}" --no-warnings --max-http-header-size=65536 --tls-min-v1.0 $NODE_OPTIONS "${DIR}/src/cli" ${@}

docs/setup/settings.asciidoc

@@ -225,13 +225,13 @@ deprecated:[5.3.0,Replaced by `server.ssl.certificate`]
 
 `server.ssl.certificateAuthorities:`:: List of paths to PEM encoded certificate files that should be trusted.
 
-`server.ssl.cipherSuites:`:: *Default: ECDHE-RSA-AES128-GCM-SHA256, ECDHE-ECDSA-AES128-GCM-SHA256, ECDHE-RSA-AES256-GCM-SHA384, ECDHE-ECDSA-AES256-GCM-SHA384, DHE-RSA-AES128-GCM-SHA256, ECDHE-RSA-AES128-SHA256, DHE-RSA-AES128-SHA256, ECDHE-RSA-AES256-SHA384, DHE-RSA-AES256-SHA384, ECDHE-RSA-AES256-SHA256, DHE-RSA-AES256-SHA256, HIGH,!aNULL, !eNULL, !EXPORT, !DES, !RC4, !MD5, !PSK, !SRP, !CAMELLIA*. Details on the format, and the valid options, are available via the [OpenSSL cipher list format documentation](https://www.openssl.org/docs/man1.0.2/apps/ciphers.html#CIPHER-LIST-FORMAT)
+`server.ssl.cipherSuites:`:: *Default: TLS_AES_256_GCM_SHA384, TLS_CHACHA20_POLY1305_SHA256, TLS_AES_128_GCM_SHA256, ECDHE-RSA-AES128-GCM-SHA256, ECDHE-ECDSA-AES128-GCM-SHA256, ECDHE-RSA-AES256-GCM-SHA384, ECDHE-ECDSA-AES256-GCM-SHA384, DHE-RSA-AES128-GCM-SHA256, ECDHE-RSA-AES128-SHA256, DHE-RSA-AES128-SHA256, ECDHE-RSA-AES256-SHA384, DHE-RSA-AES256-SHA384, ECDHE-RSA-AES256-SHA256, DHE-RSA-AES256-SHA256, HIGH,!aNULL, !eNULL, !EXPORT, !DES, !RC4, !MD5, !PSK, !SRP, !CAMELLIA*. Details on the format, and the valid options, are available via the [OpenSSL cipher list format documentation](https://www.openssl.org/docs/man1.1.1/man1/ciphers.html#CIPHER-LIST-FORMAT)
 
 `server.ssl.keyPassphrase:`:: The passphrase that will be used to decrypt the private key. This value is optional as the key may not be encrypted.
 
 `server.ssl.redirectHttpFromPort:`:: Kibana will bind to this port and redirect all http requests to https over the port configured as `server.port`.
 
-`server.ssl.supportedProtocols:`:: *Default: TLSv1, TLSv1.1, TLSv1.2*  An array of supported protocols with versions. Valid protocols: `TLSv1`, `TLSv1.1`, `TLSv1.2`
+`server.ssl.supportedProtocols:`:: *Default: TLSv1, TLSv1.1, TLSv1.2, TLSv1.3*  An array of supported protocols with versions. Valid protocols: `TLSv1`, `TLSv1.1`, `TLSv1.2`, `TLSv1.3`.
 
 `status.allowAnonymous:`:: *Default: false* If authentication is enabled, setting this to `true` allows
 unauthenticated users to access the Kibana server status API and status page.

package.json

@@ -89,7 +89,7 @@
     "url": "https://github.com/elastic/kibana.git"
   },
   "resolutions": {
-    "**/@types/node": "10.12.27",
+    "**/@types/node": "12.20.14",
     "**/babel-plugin-inline-react-svg/svgo/js-yaml": "^3.13.1",
     "**/cross-fetch/node-fetch": "^2.6.1",
     "**/cypress/lodash": "^4.17.21",
@@ -294,6 +294,7 @@
     "@kbn/plugin-generator": "1.0.0",
     "@kbn/test": "1.0.0",
     "@octokit/rest": "^15.10.0",
+    "@testing-library/react": "^9.5.0",
     "@types/angular": "1.6.50",
     "@types/angular-mocks": "^1.7.0",
     "@types/babel-core": "^6.25.5",
@@ -329,7 +330,7 @@
     "@types/minimatch": "^2.0.29",
     "@types/moment-timezone": "^0.5.8",
     "@types/mustache": "^0.8.31",
-    "@types/node": "^10.12.27",
+    "@types/node": "^12.20.14",
     "@types/opn": "^5.1.0",
     "@types/prop-types": "^15.7.3",
     "@types/puppeteer-core": "^1.9.0",
@@ -439,14 +440,14 @@
     "tslint-config-prettier": "^1.15.0",
     "tslint-microsoft-contrib": "^6.0.0",
     "tslint-plugin-prettier": "^2.0.0",
-    "typescript": "^3.0.3",
+    "typescript": "~3.1.0",
     "vinyl-fs": "^3.0.2",
     "xml2js": "^0.4.19",
     "xmlbuilder": "9.0.4",
     "zlib": "^1.0.5"
   },
   "engines": {
-    "node": "10.24.1",
+    "node": "12.22.1",
     "yarn": "^1.21.1"
   }
 }

packages/kbn-config-schema/package.json

@@ -10,7 +10,7 @@
     "kbn:bootstrap": "yarn build"
   },
   "devDependencies": {
-    "typescript": "^3.0.3"
+    "typescript": "~3.1.0"
   },
   "peerDependencies": {
     "joi": "^13.5.2",

packages/kbn-dev-utils/src/tooling_log/__snapshots__/tooling_log_text_writer.test.js.snap

@@ -2,8 +2,7 @@
 
 exports[`formats %s patterns and indents multi-line messages correctly 1`] = `
 "         │ succ foo bar
-         │      { foo: { bar: { '1': [Array] } },
-         │        bar: { bar: { '1': [Array] } } }
+         │      { foo: { bar: { '1': [Array] } }, bar: { bar: { '1': [Array] } } }
          │
          │      Infinity
 "

packages/kbn-i18n/package.json

@@ -25,7 +25,7 @@
     "del": "^3.0.0",
     "getopts": "^2.2.3",
     "supports-color": "^6.1.0",
-    "typescript": "^3.0.3"
+    "typescript": "~3.1.0"
   },
   "dependencies": {
     "intl-format-cache": "^2.1.0",

packages/kbn-i18n/src/__snapshots__/loader.test.ts.snap

@@ -2,4 +2,4 @@
 
 exports[`I18n loader registerTranslationFile should throw error if path to translation file is not an absolute 1`] = `"Paths to translation files must be absolute. Got relative path: \\"./en.json\\""`;
 
-exports[`I18n loader registerTranslationFile should throw error if path to translation file is not specified 1`] = `"The \\"path\\" argument must be of type string. Received type undefined"`;
+exports[`I18n loader registerTranslationFile should throw error if path to translation file is not specified 1`] = `"The \\"path\\" argument must be of type string. Received undefined"`;

packages/kbn-pm/dist/index.js

@@ -14160,8 +14160,8 @@ function spawnStreaming(command, args, opts, { prefix }) {
         mergeMultiline: true,
         tag: `${_logSymbols2.default.error} ${color.bold(prefix)}:`
     });
-    spawned.stdout.pipe(prefixedStdout).pipe(process.stdout);
-    spawned.stderr.pipe(prefixedStderr).pipe(process.stderr);
+    spawned.stdout.pipe(prefixedStdout).pipe(process.stdout); // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+    spawned.stderr.pipe(prefixedStderr).pipe(process.stderr); // TypeScript note: As long as the proc stdio[2] is 'pipe', then stderr will not be null
     return spawned;
 }
 
@@ -20051,7 +20051,8 @@ const WatchCommand = exports.WatchCommand = {
             }
             yield (0, _parallelize.parallelizeBatches)(batchedProjects, (() => {
                 var _ref = _asyncToGenerator(function* (pkg) {
-                    const completionHint = yield (0, _watch.waitUntilWatchIsReady)(pkg.runScriptStreaming(watchScriptName).stdout);
+                    const completionHint = yield (0, _watch.waitUntilWatchIsReady)(pkg.runScriptStreaming(watchScriptName).stdout // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+                    );
                     _log.log.write(_chalk2.default.bold(`[${_chalk2.default.green(pkg.name)}] Initial build completed (${completionHint}).`));
                 });
 

packages/kbn-pm/package.json

@@ -25,7 +25,7 @@
     "@types/log-symbols": "^2.0.0",
     "@types/mkdirp": "^0.5.2",
     "@types/ncp": "^2.0.1",
-    "@types/node": "^10.12.27",
+    "@types/node": "^12.20.14",
     "@types/ora": "^1.3.2",
     "@types/read-pkg": "^3.0.0",
     "@types/strip-ansi": "^3.0.0",
@@ -62,7 +62,7 @@
     "strong-log-transformer": "^2.1.0",
     "tempy": "^0.2.1",
     "ts-loader": "^5.2.2",
-    "typescript": "^3.0.3",
+    "typescript": "~3.1.0",
     "unlazy-loader": "^0.1.3",
     "webpack": "4.26.1",
     "webpack-cli": "^3.3.5",

packages/kbn-pm/src/commands/watch.ts

@@ -85,7 +85,7 @@ export const WatchCommand: ICommand = {
 
     await parallelizeBatches(batchedProjects, async pkg => {
       const completionHint = await waitUntilWatchIsReady(
-        pkg.runScriptStreaming(watchScriptName).stdout
+        pkg.runScriptStreaming(watchScriptName).stdout! // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
       );
 
       log.write(

packages/kbn-pm/src/utils/child_process.ts

@@ -58,8 +58,8 @@ export function spawnStreaming(
     tag: `${logSymbols.error} ${color.bold(prefix)}:`,
   });
 
-  spawned.stdout.pipe(prefixedStdout).pipe(process.stdout);
-  spawned.stderr.pipe(prefixedStderr).pipe(process.stderr);
+  spawned.stdout!.pipe(prefixedStdout).pipe(process.stdout); // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+  spawned.stderr!.pipe(prefixedStderr).pipe(process.stderr); // TypeScript note: As long as the proc stdio[2] is 'pipe', then stderr will not be null
 
   return spawned;
 }

src/cli/serve/integration_tests/invalid_config.test.js

@@ -46,7 +46,7 @@ describe('cli invalid config support', function () {
 
     expect(error).toBe(undefined);
     expect(status).toBe(64);
-    expect(fatalLogLine.message).toMatch('{ Error: "unknown.key", "other.unknown.key", "other.third", "some.flat.key", and "' +
+    expect(fatalLogLine.message).toMatch('Error: "unknown.key", "other.unknown.key", "other.third", "some.flat.key", and "' +
       'some.array" settings were not applied. Check for spelling errors and ensure that expected plugins are installed.');
     expect(fatalLogLine.tags).toEqual(['fatal', 'root']);
     expect(fatalLogLine.type).toEqual('log');

src/core/public/utils/modify_url.test.ts

@@ -53,7 +53,7 @@ it('supports changing protocol', () => {
     modifyUrl('http://localhost', parsed => {
       parsed.protocol = 'mail';
       parsed.slashes = false;
-      parsed.pathname = undefined;
+      parsed.pathname = null;
     })
   ).toBe('mail:localhost');
 });

src/core/public/utils/modify_url.ts

@@ -20,14 +20,14 @@
 import { format as formatUrl, parse as parseUrl } from 'url';
 
 interface UrlParts {
-  protocol?: string;
-  slashes?: boolean;
-  auth?: string;
-  hostname?: string;
-  port?: string;
-  pathname?: string;
+  protocol: string | null;
+  slashes: boolean | null;
+  auth: string | null;
+  hostname: string | null;
+  port: string | null;
+  pathname: string | null;
   query: { [key: string]: string | string[] | undefined };
-  hash?: string;
+  hash: string | null;
 }
 
 /**

src/core/server/http/__snapshots__/http_config.test.ts.snap

@@ -21,6 +21,9 @@ Object {
   "rewriteBasePath": false,
   "ssl": Object {
     "cipherSuites": Array [
+      "TLS_AES_256_GCM_SHA384",
+      "TLS_CHACHA20_POLY1305_SHA256",
+      "TLS_AES_128_GCM_SHA256",
       "ECDHE-RSA-AES128-GCM-SHA256",
       "ECDHE-ECDSA-AES128-GCM-SHA256",
       "ECDHE-RSA-AES256-GCM-SHA384",
@@ -60,14 +63,16 @@ exports[`with TLS should accept known protocols\` 1`] = `
 "[ssl.supportedProtocols.0]: types that failed validation:
 - [ssl.supportedProtocols.0.0]: expected value to equal [TLSv1] but got [SOMEv100500]
 - [ssl.supportedProtocols.0.1]: expected value to equal [TLSv1.1] but got [SOMEv100500]
-- [ssl.supportedProtocols.0.2]: expected value to equal [TLSv1.2] but got [SOMEv100500]"
+- [ssl.supportedProtocols.0.2]: expected value to equal [TLSv1.2] but got [SOMEv100500]
+- [ssl.supportedProtocols.0.3]: expected value to equal [TLSv1.3] but got [SOMEv100500]"
 `;
 
 exports[`with TLS should accept known protocols\` 2`] = `
 "[ssl.supportedProtocols.3]: types that failed validation:
 - [ssl.supportedProtocols.3.0]: expected value to equal [TLSv1] but got [SOMEv100500]
 - [ssl.supportedProtocols.3.1]: expected value to equal [TLSv1.1] but got [SOMEv100500]
-- [ssl.supportedProtocols.3.2]: expected value to equal [TLSv1.2] but got [SOMEv100500]"
+- [ssl.supportedProtocols.3.2]: expected value to equal [TLSv1.2] but got [SOMEv100500]
+- [ssl.supportedProtocols.3.3]: expected value to equal [TLSv1.3] but got [SOMEv100500]"
 `;
 
 exports[`with TLS throws if TLS is enabled but \`certificate\` is not specified 1`] = `"[ssl]: must specify [certificate] and [key] when ssl is enabled"`;

src/core/server/http/http_server.test.ts

@@ -543,7 +543,7 @@ describe('with defined `redirectHttpFromPort`', () => {
       ...config,
       ssl: {
         certificate: '/certificate',
-        cipherSuites: ['cipherSuite'],
+        cipherSuites: ['TLS_AES_256_GCM_SHA384'],
         enabled: true,
         getSecureOptions: () => 0,
         key: '/key',

src/core/server/http/ssl_config.ts

@@ -18,16 +18,14 @@
  */
 
 import { schema, TypeOf } from '@kbn/config-schema';
-import crypto from 'crypto';
-
-// `crypto` type definitions doesn't currently include `crypto.constants`, see
-// https://github.com/DefinitelyTyped/DefinitelyTyped/blob/fa5baf1733f49cf26228a4e509914572c1b74adf/types/node/v6/index.d.ts#L3412
-const cryptoConstants = (crypto as any).constants;
+import { constants as cryptoConstants } from 'crypto';
 
 const protocolMap = new Map<string, number>([
   ['TLSv1', cryptoConstants.SSL_OP_NO_TLSv1],
   ['TLSv1.1', cryptoConstants.SSL_OP_NO_TLSv1_1],
   ['TLSv1.2', cryptoConstants.SSL_OP_NO_TLSv1_2],
+  // @ts-ignore According to the docs SSL_OP_NO_TLSv1_3 should exist (https://nodejs.org/docs/latest-v12.x/api/crypto.html)
+  ['TLSv1.3', cryptoConstants.SSL_OP_NO_TLSv1_3],
 ]);
 
 const sslSchema = schema.object(
@@ -51,6 +49,7 @@ const sslSchema = schema.object(
           schema.literal('TLSv1'),
           schema.literal('TLSv1.1'),
           schema.literal('TLSv1.2'),
+          schema.literal('TLSv1.3'),
         ])
       )
     ),

src/core/server/logging/appenders/file/file_appender.test.ts

@@ -152,7 +152,7 @@ test('`dispose()` succeeds even if stream is not created.', async () => {
 
 test('`dispose()` closes stream.', async () => {
   const mockStreamEndFinished = jest.fn();
-  const mockStreamEnd = jest.fn(async (chunk, encoding, callback) => {
+  const mockStreamEnd = jest.fn(async callback => {
     // It's required to make sure `dispose` waits for `end` to complete.
     await tickMs(100);
     mockStreamEndFinished();
@@ -177,7 +177,7 @@ test('`dispose()` closes stream.', async () => {
   await appender.dispose();
 
   expect(mockStreamEnd).toHaveBeenCalledTimes(1);
-  expect(mockStreamEnd).toHaveBeenCalledWith(undefined, undefined, expect.any(Function));
+  expect(mockStreamEnd).toHaveBeenCalledWith(expect.any(Function));
   expect(mockStreamEndFinished).toHaveBeenCalled();
 
   // Consequent `dispose` calls should not fail even if stream has been disposed.

src/core/server/logging/appenders/file/file_appender.ts

@@ -71,7 +71,7 @@ export class FileAppender implements DisposableAppender {
         return resolve();
       }
 
-      this.outputStream.end(undefined, undefined, () => {
+      this.outputStream.end(() => {
         this.outputStream = undefined;
         resolve();
       });

src/core/server/plugins/discovery/plugins_discovery.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { readdir, stat } from 'fs';
+import Fs from 'fs';
 import { resolve } from 'path';
 import { bindNodeCallback, from } from 'rxjs';
 import { catchError, filter, map, mergeMap, shareReplay } from 'rxjs/operators';
@@ -29,8 +29,8 @@ import { PluginsConfig } from '../plugins_config';
 import { PluginDiscoveryError } from './plugin_discovery_error';
 import { parseManifest } from './plugin_manifest_parser';
 
-const fsReadDir$ = bindNodeCallback(readdir);
-const fsStat$ = bindNodeCallback(stat);
+const fsReadDir$ = bindNodeCallback(Fs.readdir);
+const fsStat$ = bindNodeCallback<Fs.PathLike, Fs.Stats>(Fs.stat);
 
 /**
  * Tries to discover all possible plugins based on the provided plugin config.

src/dev/build/lib/scan_delete.ts

@@ -27,7 +27,7 @@ import { count, map, mergeAll, mergeMap } from 'rxjs/operators';
 // @ts-ignore
 import { assertAbsolute } from './fs';
 
-const getStat$ = Rx.bindNodeCallback(Fs.stat);
+const getStat$ = Rx.bindNodeCallback<Fs.PathLike, Fs.Stats>(Fs.stat);
 const getReadDir$ = Rx.bindNodeCallback(Fs.readdir);
 
 interface Options {

src/dev/build/tasks/patch_native_modules_task.js

@@ -31,16 +31,16 @@ const packages = [
     extractMethod: 'gunzip',
     archives: {
       darwin: {
-        url: 'https://github.com/uhop/node-re2/releases/download/1.14.0/darwin-x64-64.gz',
-        sha256: '54c8386cb7cd53895cf379522114bfe82378e300e127e58d392ddd40a77e396f',
+        url: 'https://github.com/uhop/node-re2/releases/download/1.14.0/darwin-x64-72.gz',
+        sha256: '7a8d422fe99052ff8cbe52080b2bbb0128eb84b9c9a14adc5269106716972af1',
       },
       linux: {
-        url: 'https://github.com/uhop/node-re2/releases/download/1.14.0/linux-x64-64.gz',
-        sha256: 'f54f059035e71a7ccb3fa201080e260c41d228d13a8247974b4bb157691b6757',
+        url: 'https://github.com/uhop/node-re2/releases/download/1.14.0/linux-x64-72.gz',
+        sha256: 'b219aaca9424b381ef6c000b6cdd8ff30cb97df1005966e21be3b92a9ebb60e3',
       },
       windows: {
-        url: 'https://github.com/uhop/node-re2/releases/download/1.14.0/win32-x64-64.gz',
-        sha256: 'de708446a8b802f4634c2cfef097c2625a2811fdcd8133dfd7b7c485f966caa9',
+        url: 'https://github.com/uhop/node-re2/releases/download/1.14.0/win32-x64-72.gz',
+        sha256: 'c90995d15a1b1b59724ca2c41b145be67354bd90465a4c1bfe075c62a081ad3f',
       },
     },
   },

src/dev/precommit_hook/casing_check_config.js

@@ -47,6 +47,7 @@ export const IGNORE_FILE_GLOBS = [
   'Dockerfile*',
   'vars/*',
   '.ci/pipeline-library/**/*',
+  'x-pack/typings/@testing-library/react/index.d.ts',
 
   // filename must match language code which requires capital letters
   '**/translations/*.json',

src/es_archiver/actions/load.js

@@ -42,7 +42,7 @@ import {
 const pipeline = (...streams) => streams
   .reduce((source, dest) => (
     source
-      .once('error', (error) => dest.emit('error', error))
+      .once('error', (error) => dest.destroy(error))
       .pipe(dest)
   ));
 

src/legacy/core_plugins/console/public/tests/src/integration.test.js

@@ -682,7 +682,7 @@ describe('Integration', () => {
       {
         name: 'Any of - mixed - both',
         cursor: { row: 13, column: 2 },
-        autoCompleteSet: [tt('{'), tt(3)],
+        autoCompleteSet: [tt(3), tt('{')],
       },
     ]
   );

src/legacy/core_plugins/inspector_views/public/data/__snapshots__/data_view.test.js.snap

@@ -12,6 +12,7 @@ exports[`Inspector Data View component should render empty state 1`] = `
         "_maxListeners": undefined,
         "tabular": [Function],
         "tabularOptions": Object {},
+        Symbol(kCapture): false,
       },
     }
   }
@@ -222,6 +223,7 @@ exports[`Inspector Data View component should render loading state 1`] = `
         },
         "_eventsCount": 1,
         "_maxListeners": undefined,
+        Symbol(kCapture): false,
       },
     }
   }

src/optimize/public_path_placeholder.js

@@ -35,7 +35,7 @@ export function replacePlaceholder(read, replacement) {
     takeUntil(Rx.fromEvent(read, 'end'))
   )
     .forEach(error => {
-      replace.emit('error', error);
+      replace.destroy(error);
       replace.end();
     });