-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shared UX] Move No Data Cards to packages #134503
[Shared UX] Move No Data Cards to packages #134503
Conversation
d623810
to
bc5ff11
Compare
packages/shared-ux/card/no_data_elastic_agent/src/no_data_elastic_agent_card.tsx
Outdated
Show resolved
Hide resolved
bc5ff11
to
1849bf9
Compare
143316b
to
1886fcd
Compare
1886fcd
to
a770167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this in storybook in Chrome on Mac OSX, works as expected.
Made a quick pass through the code, but not too detailed, since it's just moving files around I assume there were no major changes. Looks like Solutions are using the card already, so we'll need to make changes there as well.
b7e2916
to
ed5dd0f
Compare
It took more work to get this over the line than I would have liked... in commits since @majagrubic approved this PR, I:
So I'm requesting @elastic/shared-ux have another look at this before I commit it. Thanks! |
@@ -27,4 +22,6 @@ type Props = Omit<ComponentProps, 'navigateToUrl' | 'currentAppId'>; | |||
* </RedirectAppLinks> | |||
* ``` | |||
*/ | |||
export const RedirectAppLinks = (props: Props) => <Component {...useServices()} {...props} />; | |||
export const RedirectAppLinks: FC<{}> = ({ children }) => ( | |||
<Component {...useServices()}>{children}</Component> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, haven't tested it this time.
c7b2e55
to
d55e52d
Compare
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
This PR:
NoDataCard
andNoDataElasticAgentCard
to their own packages.NoDataElasticAgentCard
.