[New platform] Export types from root levels #33973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
mshustov
changed the title
💚 Build Succeeded |
eliperelman
suggested changes
Mar 29, 2019
src/legacy/ui/public/chrome/directives/header_global_nav/components/header.tsx
Outdated
Show resolved
Hide resolved
src/legacy/ui/public/chrome/directives/header_global_nav/components/header_breadcrumbs.test.tsx
Outdated
Show resolved
Hide resolved
src/legacy/ui/public/chrome/directives/header_global_nav/components/header_breadcrumbs.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: restrry <[email protected]>
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Mar 29, 2019
* export flatten types from the root * add Chrome prefix for chrome types * export types for server services * remove comment * cleanup CoreSetup types * rename to setup * Apply @eliperelman suggestions from code review Co-Authored-By: restrry <[email protected]>
mshustov
added a commit
that referenced
this pull request
Mar 29, 2019
* export flatten types from the root * add Chrome prefix for chrome types * export types for server services * remove comment * cleanup CoreSetup types * rename to setup * Apply @eliperelman suggestions from code review Co-Authored-By: restrry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #33963
Export types from root levels
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers