[precommit] lint ts files with eslint #36218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations |
dgieselaar
approved these changes
May 7, 2019
mistic
approved these changes
May 7, 2019
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 7, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 7, 2019
spalger
pushed a commit
that referenced
this pull request
May 8, 2019
spalger
pushed a commit
that referenced
this pull request
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dgieselaar noticed that TypeScript files are not being linted in the precommit hook, due to a filter that only lets js files pass. Adding a
file.isTypescript()check there fixes the problem.Seems this has been a problem #33826