Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb is recompiled after the slightest change to cargo command #11

Open
Logarithmus opened this issue Oct 7, 2021 · 0 comments · May be fixed by #12
Open

rocksdb is recompiled after the slightest change to cargo command #11

Logarithmus opened this issue Oct 7, 2021 · 0 comments · May be fixed by #12
Labels
bug Something isn't working

Comments

@Logarithmus
Copy link
Contributor

Logarithmus commented Oct 7, 2021 •
edited
Loading

cc recompiles rocksdb every time after the slightest changes to cargo command (e.g. running cargo doc after cargo check results in recompilation of rocksdb C++ code, even if C++ code didn't change at all.
@Logarithmus Logarithmus added the bug Something isn't working label Oct 7, 2021
@Logarithmus Logarithmus self-assigned this Oct 7, 2021
Logarithmus added a commit that referenced this issue Oct 7, 2021
@Logarithmus
Fix RocksDB ccache cache misses leading to pointless recompilations
18029b1 
Previously `cc` recompiled `rocksdb` every time after the slightest
changes to `cargo` command (e.g. running cargo doc after `cargo check`
resulted in recompilation of `rocksdb` C++ code, even if C++ code
didn't change at all. This was due to use of absolute paths containing
e.g. `roxide-librocksdb-sys-c294a8e66ff58e21`, where `c294a8e66ff58e21`
part changed after the slightest change to `cargo` command.

- Move dummy wrapper files: `target/` -> `roxide-librocksdb-sys/build/`
- Perform cosmetic changes to comments
- Add a reminder to investigate if wrapper files hack is still needed

Closes #11
@Logarithmus Logarithmus linked a pull request Oct 7, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RocksDB ccache cache misses leading to pointless recompilations elastio/roxide
1 participant
@Logarithmus