chore(app-backend): Use v9 #7435
Conversation
VIKTORVAV99
requested review from
silkeholmebonnen,
cadeban and
tonypls
and removed request for
a team
|
All hands on deck to review this one to ensure I haven't missed some usage of the old token and that it works as expected with the auth. If you need the new token for local evaluation let me know :) |
| @@ -36,7 +36,7 @@ build: | |||
| FROM +prepare | |||
| RUN pnpm run create-generated-files | |||
| RUN pnpm version minor | |||
| RUN --secret SENTRY_AUTH_TOKEN --secret VITE_PUBLIC_ELECTRICITYMAP_PUBLIC_TOKEN=ELECTRICITYMAP_PUBLIC_TOKEN pnpm run build | |||
| RUN --secret SENTRY_AUTH_TOKEN --secret VITE_PUBLIC_ELECTRICITYMAP_PUBLIC_TOKEN_V9=ELECTRICITYMAPS_APP_PUBLIC_TOKEN_V9 pnpm run build | |||
There was a problem hiding this comment.
I think we need a backend PR to add this to .drone-earthly.yml
There was a problem hiding this comment.
I think we need a backend PR to add this to
.drone-earthly.yml
Don't we get this from the secret manager directly?
And where is this file, I can't seem to find it in contrib? 👀
There was a problem hiding this comment.
It's in the mono-repo. It's how earthly will get the secrets when it's building the bundle to deploy to prod
There was a problem hiding this comment.
It's in the mono-repo. It's how earthly will get the secrets when it's building the bundle to deploy to prod
Really? 👀
I haven't been adding parser tokens there either as far as I remember and they still work. I'll double check though, but the backend deployment was working fine without it.
There was a problem hiding this comment.
Was that not for when we deployed it to instance 1 and ran it ourself rather than hosted it on Cloudflare?
The first backend PR is already merged, that is why this is working ;) |
Issue
Closes: AVO-641
Closes: AVO-649
Description
Needs: https://github.com/electricitymaps/electricitymaps/pull/5975
Switches the paths to v9 and enables auth for the state path.
It also switches the tokens and env variables to the correct one for v9.
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.