Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mongolia parser, add thermal + battery support [Mostly complete, needs some work so if someone else wants to complete this please do] #7444

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

q--
Copy link
Contributor

@q-- q-- commented Nov 22, 2024

Issue

See #5906

Description

Fixes the Mongolia parser by correcting a renamed field in the API, determining that 'Songino' stands for battery (#5906 (comment)). It also maps tpp to thermal.

Still to be done:

  • From now on, I'm assuming that tpp = thermal and any remaining production = hydro, so 'unknown' needs to have an override for oil + coal instead of oil + coal + hydro. Keep the old override for the old data though, that's not based on tpp production but on total unaccounted for production and therefore should include hydro).
  • Test if it works
  • Formatting

(I wrote this in the GitHub web editor hoping to give someone else a starting point for fixing this, if someone else can do the last steps that would be appreciated. May even be tagged 'help wanted'.)

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code labels Nov 22, 2024
@VIKTORVAV99
Copy link
Member

Looks good from a first glance!

There is a risk that unknown can contain other types than just hydro as we don't know if all of their production modes are actually reported properly for all plants. But I think this is a reasonable assumption to make given the available data.

I can take a look at it later today and add the needed override values. Sadly other contributors can't edit existing PR, only EMaps members can.

@VIKTORVAV99 VIKTORVAV99 self-assigned this Nov 23, 2024
@q--
Copy link
Contributor Author

q-- commented Nov 23, 2024 via email

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Nov 23, 2024
@@ -46,6 +49,9 @@ emissionFactors:
datetime: '2020-01-01'
source: IEA 2020; assumes 92.85% coal, 5.78%% oil, 1.37% hydro in unknown
value: 799.2
- datetime: '2024-11-25'
source: IEA 2020; assumes 94.14% coal, 5.86% oil in unknown
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This source also says IEA 2020 but has different values from two lines up, is that correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, basically I used the same source but simply removed hydro since that will now be reported on it's own.

@VIKTORVAV99 VIKTORVAV99 requested review from FelixDQ and annaib00 and removed request for VIKTORVAV99 November 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser python Pull requests that update Python code zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants