fix(windows,code-sign): cannot sign binary files

Fixed: #7729 #8055 Signed-off-by: Kevin Cui <[email protected]>
electron-userland · Jul 29, 2024 · 32897b1 · 32897b1
1 parent 977acaf
commit 32897b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.changeset/good-news-stare.md b/.changeset/good-news-stare.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+Fix the issue of being unable to sign binary files in the Windows runner on Github Actions
diff --git a/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts b/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts
@@ -110,9 +110,7 @@ export interface CertificateFromStoreInfo {
 export async function getCertificateFromStoreInfo(options: WindowsConfiguration, vm: VmManager): Promise<CertificateFromStoreInfo> {
   const certificateSubjectName = options.certificateSubjectName
   const certificateSha1 = options.certificateSha1 ? options.certificateSha1.toUpperCase() : options.certificateSha1
-  // ExcludeProperty doesn't work, so, we cannot exclude RawData, it is ok
-  // powershell can return object if the only item
-  const rawResult = await vm.exec("powershell.exe", [
+  const rawResult = await vm.exec("pwsh.exe", [
     "-NoProfile",
     "-NonInteractive",
     "-Command",