Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch teamId from environment variables instead of hardcoding in package.json #7812

Closed
GaurangTandon opened this issue Oct 6, 2023 · 2 comments · Fixed by #8159
Closed

Comments

@GaurangTandon
Copy link

  • Electron-Builder Version: 24.4.0 - I have checked the source code and this behavior hasn't changed in newer versions.
  • Node Version: 18.17.1

The problem is not Electron related.

  • Target: macOS (arm or intel - either chip)

To use the notarytool, we need to hardcode our Apple Developer teamId in the package.json, like so:

"build": {
  "mac": {
    "notarize": {
      "teamId": "<my-team-id>"
    }
  }
}

I would prefer to keep all packaging variables in one place. I already have all the secrets in an environment file. If possible, can we also move teamId to an environment variable? For example, APPLE_TEAM_ID.

I am happy to send a PR for this if the maintainers approve this suggestion.

@yuhki50
Copy link

yuhki50 commented Nov 1, 2023

Use electron-builder.js file

module.exports = {
  mac: {
    notarize: {
      teamId: process.env.APPLE_TEAM_ID,
    },
  },
};

@mmaietta
Copy link
Collaborator

mmaietta commented Apr 3, 2024

Released in v25.0.0-alpha.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants