feat: yarn 3 support for native modules #8112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder` default: `true` to support Yarn 3
…-rebuild-migration # Conflicts: # .changeset/pre.json
🦋 Changeset detectedLatest commit: 8db8e5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: implementing electron/rebuild with config option
nativeRebuilderdefault:legacyto preserve current functionality.Yarn 3 removed the implicit link between
installandrebuildsteps, now requiringrebuildto be called directly. electron-builder's native rebuilding utilizesapp-builderGo binary, which is not actively maintained and does not support yarn 3.Setting
nativeRebuilder: 'sequential' // or 'parallel'will utilize electron/rebuild during both the dependency installation phase (to make sure native modules are built the first time sinceinstallsimply doesn't trigger it) and used again for any subsequent builds (such as mac universal builds).sequentialandparallelvalues determine theRebuildModefor electron/rebuildThis inadvertently also enables reactivating a native module test that couldn't run with
app-builderdue to the native dependencynode-mac-permissionsnot having an actualinstallstep, electron/rebuild bypasses that and allows the binaries to be compiled and lipo'd into a universal build.Fixes: #8024