Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quotes to surround file path during azure signing to handle files with spaces #8606

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mmaietta
Copy link
Collaborator

Fixes: #8600

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 0d3a7ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 0d3a7ea
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/670fd501a7a1e80008d415f6
😎 Deploy Preview https://deploy-preview-8606--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit a0e635c into master Oct 16, 2024
15 checks passed
@mmaietta mmaietta deleted the fix/file-path-spaces-azure-signing branch October 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Trusted Signing fails when there are spaces in the file path
1 participant