fix: Remove path from published binaries #8631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4e8ebfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for car-park-attendant-cleat-11576 failed.
|
olivereisenhut
force-pushed
the
fix/path-in-published-filename
branch
from
07f06de to
39bdec8
Compare
During refactoring electron-userland#8596, the `basename` import was changed from "path" to "path/posix", which doesn't properly reduce to the base name. This caused some filenames to contain the absolute path after publishing.
olivereisenhut
force-pushed
the
fix/path-in-published-filename
branch
from
39bdec8 to
c144972
Compare
|
Released in v26.0.0-alpha.4. Thank you @olivereisenhut ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During refactoring #8596, the
basenameimport was changed from "path" to "path/posix", which doesn't properly reduce to the base name.This caused some filenames to contain the absolute path after publishing.