Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove osr framerate limit when use shared texture #45669

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

reitowo
Copy link
Contributor

@reitowo reitowo commented Feb 18, 2025

Description of Change

Remove 240 FPS limit of OSR when using shared texture, because there's no performance limit.

Release Notes

Notes: Remove 240 FPS limit when use shared texture OSR.

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe this change a bit more? Do you know why we might have initially wanted it? Depending on my understanding of what's happening here, I don't think we probably need to do a full API review circuit here cc @electron/wg-api

@reitowo
Copy link
Contributor Author

reitowo commented Feb 18, 2025

This is splitted from #45539. Initially, OSR can't avoid copy texture from GPU to CPU (GPU accelerated mode), or CPU rendering (CPU mode), so it can't really goes beyond 240 fps because of the overhead. So I think its reasonable to set a 240 fps limit there.

As we now have shared texture OSR, it just copy GPU handle, and almost have no overhead. I think it is better to remove the limit in that case because it can goes easily beyond 240.

@samuelmaddock samuelmaddock added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. labels Feb 18, 2025
@samuelmaddock
Copy link
Member

I don't think we probably need to do a full API review circuit here

I tagged as semver/patch to avoid requiring the full API review. The change is also small enough, but lmk if others disagree with this decision.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 19, 2025
@reitowo reitowo force-pushed the main-osr-remove-limit branch from ada542a to f1e155e Compare February 24, 2025 01:28
@reitowo
Copy link
Contributor Author

reitowo commented Feb 24, 2025

Rebased, please rerun the CI.

@jkleinsc jkleinsc merged commit f3259be into electron:main Feb 24, 2025
56 checks passed
Copy link

release-clerk bot commented Feb 24, 2025

Release Notes Persisted

Remove 240 FPS limit when use shared texture OSR.

@trop
Copy link
Contributor

trop bot commented Feb 24, 2025

I have automatically backported this PR to "35-x-y", please check out #45781

@trop trop bot added in-flight/35-x-y and removed target/35-x-y PR should also be added to the "35-x-y" branch. labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-flight/35-x-y semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants