-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove osr framerate limit when use shared texture #45669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe this change a bit more? Do you know why we might have initially wanted it? Depending on my understanding of what's happening here, I don't think we probably need to do a full API review circuit here cc @electron/wg-api
This is splitted from #45539. Initially, OSR can't avoid copy texture from GPU to CPU (GPU accelerated mode), or CPU rendering (CPU mode), so it can't really goes beyond 240 fps because of the overhead. So I think its reasonable to set a 240 fps limit there. As we now have shared texture OSR, it just copy GPU handle, and almost have no overhead. I think it is better to remove the limit in that case because it can goes easily beyond 240. |
I tagged as |
ada542a
to
f1e155e
Compare
Rebased, please rerun the CI. |
Release Notes Persisted
|
I have automatically backported this PR to "35-x-y", please check out #45781 |
Description of Change
Remove 240 FPS limit of OSR when using shared texture, because there's no performance limit.
Release Notes
Notes: Remove 240 FPS limit when use shared texture OSR.