refactor: do not use AdaptCallbackForRepeating() in electron_api_url_loader.cc
#45771
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
semver/patch
jkleinsc
approved these changes
Feb 24, 2025
jkleinsc
deleted the
refactor/remove-some-AdaptCallbackForRepeating-calls
branch
|
No Release Notes |
This was referenced Feb 24, 2025
|
I have automatically backported this PR to "34-x-y", please check out #45782 |
trop
bot
added
in-flight/34-x-y
and removed
target/34-x-y
|
I have automatically backported this PR to "33-x-y", please check out #45783 |
|
I have automatically backported this PR to "35-x-y", please check out #45784 |
trop
bot
added
in-flight/33-x-y
in-flight/35-x-y
and removed
target/33-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Partial fix for #29739
Upstream removed
base::AdaptCallbackForRepeating()a long time ago. We still use it, so we have a Chromium patch to patch it back in. This PR fixes a couple of instances of this call, moving towards removing that patch.Checklist
npm testpassesRelease Notes
Notes: none.