Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): update grammar #1227

Merged
merged 1 commit into from
Jul 14, 2021
Merged

docs(readme): update grammar #1227

merged 1 commit into from
Jul 14, 2021

Conversation

ksb86
Copy link
Contributor

@ksb86 ksb86 commented Mar 17, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@welcome
Copy link

welcome bot commented Mar 17, 2021

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@ksb86 ksb86 changed the title minor grammar update in readme update grammar in readme Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #1227 (6406a7b) into master (0d3f843) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          698       698           
=========================================
  Hits           698       698           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3f843...6406a7b. Read the comment docs.

@ksb86 ksb86 changed the title update grammar in readme docs: update grammar in readme Mar 17, 2021
@malept malept changed the title docs: update grammar in readme docs(readme): update grammar Jul 14, 2021
@malept malept merged commit c30e584 into electron:master Jul 14, 2021
@welcome
Copy link

welcome bot commented Jul 14, 2021

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants