Fix for issue 300: --icon option does not work under Electron 0.37.4 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest creating a new (separate) test fixture project just for test/mac.js that has the Electron version set to 0.37.4, then add a testcase for the new |
malept
added
tests-needed
erkyrath
force-pushed
the
issue-300-iconname
branch
from
e9d9507 to
1d02394
Compare
Add a separate fixture for electron 0.37.4. Drop in the el-0374 test. Add pre-test setup for 0.37.4 tests.
|
Okay, added fixture and test as described. |
| series([ | ||
| function (cb) { | ||
| console.log('Calling electron-download before running tests...') | ||
| util.downloadAll(config.version, cb) | ||
| }, function (cb) { | ||
| console.log('Calling electron-download 0.37.4 before running tests...') | ||
| util.downloadAll('0.37.4', cb) |
There was a problem hiding this comment.
It doesn't need to download all of the Electron zips for 0.37.4, just the OSX ones.
There was a problem hiding this comment.
Never mind, there's more special changes in this release (see #298).
|
LGTM |
This was referenced Apr 6, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#300
This is an easy fix. It writes the icon to the filename defined in CFBundleIconFile, so it will work in Electron 0.37.4 as well as earlier versions.
Since the test/config.json specifies "0.35.6", there's no way to test this fix directly. Is that okay, or should we figure out how to test both configurations? (If so, how?)