fix: add std=c++17 flag for e20+ #1022
Conversation
|
Is this a |
VerteDinde
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
- Coverage 76.38% 76.01% -0.38%
==========================================
Files 19 19
Lines 686 692 +6
Branches 131 133 +2
==========================================
+ Hits 524 526 +2
- Misses 118 120 +2
- Partials 44 46 +2
Continue to review full report at Codecov.
|
|
@malept Looks like we don't have any unit tests for clang-fetcher - I'll see if I can add some |
There was a problem hiding this comment.
This is good for now and solves a real problem.
For electron/electron I'm working on some solution that would provide the build flags that come from upstream so that we don't have to hardcode a particular version. However in practice this is only going to change every few years (any predictions on when Chromium will jump to C++20?)
Also, upstream hardcodes this in several places too, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/3306812 for one example.
👍 on tests but since there weren't any before, I wouldn't block on it
|
🎉 This PR is included in version 3.2.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Addresses e/e issue 34209 while 20.0.0-beta.1 is in beta.
This PR adds a compile flag for
-std=c++17when using Electron 20 or higher.