Skip to content

Commit

Permalink
feat(node): drop node 8 support due to its EOL
Browse files Browse the repository at this point in the history
Dropped node 8 support due to its EOL

BREAKING CHANGE: Users with node v8 will not be actively supported.

fix #231
  • Loading branch information
onderceylan committed May 14, 2020
1 parent 505140d commit df91a1f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: true
matrix:
node: [8, 10, 12]
node: [10, 12, 13]
os: [ubuntu-latest, macOS-latest, windows-latest]

steps:
Expand All @@ -24,8 +24,6 @@ jobs:
- name: install
run: npm install
- name: lint
# Prettier runs are disabled on node 8 as prettier >v2 doesn't support this env
if: matrix.node != 8
run: npm run lint
- name: build
run: npm run build
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"url": "https://github.com/onderceylan/pwa-asset-generator.git"
},
"engines": {
"node": ">=8.16.0"
"node": ">=10"
},
"keywords": [
"pwa",
Expand Down

0 comments on commit df91a1f

Please sign in to comment.