Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets are not created in current folder if output param is not provided #1

Closed
azakharow opened this issue Aug 14, 2019 · 2 comments
Closed

Assets are not created in current folder if output param is not provided #1

azakharow opened this issue Aug 14, 2019 · 2 comments
Assignees
@onderceylan
Labels
bug Something isn't working released

Comments

@azakharow
Copy link

Readme tells that "The assets will be saved to the folder where the command is executed if no output-folder provided". To check this point, I'm executing the example from Readme without output folder provided like that:
pwa-asset-generator https://cdn.freebiesupply.com/logos/large/2x/amazon-icon-logo-png-transparent.png -p "20%" -b "linear-gradient(to top, #fad0c4 0%, #ffd1ff 100%)"

It gives me an error:
cli TypeError: path must be a string or Buffer
@onderceylan
Copy link
Collaborator

Hey @azakharow, I noticed the same issue myself. I’m going to fix it, thanks for raising!

@onderceylan onderceylan added the bug Something isn't working label Aug 14, 2019
onderceylan pushed a commit that referenced this issue Aug 14, 2019
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
7cc2050 
## [1.0.1](v1.0.0...v1.0.1) (2019-08-14)

### Bug Fixes

* **cli:** fixed the issue when output is not provided ([b7102e7](b7102e7)), closes [#1](#1)
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@onderceylan onderceylan self-assigned this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onderceylan @azakharow