Incorrect file paths generated on Windows #36
Assignees
Labels
Comments
leonelngande
added
bug
onderceylan
removed
the
needs verification
|
Thanks for the issue @leonelngande! We need to fix the path issues on Windows asap. |
|
Okay! Should I look into it? Have had a look at |
|
Please, I'd appreciate that as I have to spin off a VM to inspect. Feel free to work on it. |
|
Great! On it thanks. |
leonelngande
added a commit
to leonelngande/pwa-asset-generator
that referenced
this issue
Aug 30, 2019
… added to icon and html content Introduce the slash npm package to use in converting backslash paths generated for saved images to slash paths, which are needed for generated html and manifest json content fix elegantapp#36
leonelngande
added a commit
to leonelngande/pwa-asset-generator
that referenced
this issue
Aug 30, 2019
Introduce a function to get the relative image path, replacing ternary expressions currently being used for same functionality with it re elegantapp#36
onderceylan
pushed a commit
that referenced
this issue
Aug 30, 2019
… added to icon and html content Introduce the slash npm package to use in converting backslash paths generated for saved images to slash paths, which are needed for generated html and manifest json content fix #36
onderceylan
pushed a commit
that referenced
this issue
Aug 30, 2019
Introduce a function to get the relative image path, replacing ternary expressions currently being used for same functionality with it re #36
onderceylan
pushed a commit
that referenced
this issue
Aug 30, 2019
## [1.1.7](v1.1.6...v1.1.7) (2019-08-30) ### Bug Fixes * **file.js, pwa.js, package.json:** fix Windows backslash paths being added to icon and html content ([24fef99](24fef99)), closes [#36](#36)
|
🎉 This issue has been resolved in version 1.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On Windows, the asset paths generated have double back-slashes (sometimes three) at the first directory level. This causes cli.test.js to fail, also user has to manually correct the asset paths generated.
To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/onderceylan/pwa-asset-generator.gitcdto project root and execute cli command:npm run jestExpected behavior
cli.test.js should pass
System (please complete the following information):
Screenshots
The text was updated successfully, but these errors were encountered: