Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash screens for iPhone 6/7/8 Plus have the wrong resultion #391

Closed
fabianeichinger opened this issue Sep 4, 2020 · 3 comments
Closed

Splash screens for iPhone 6/7/8 Plus have the wrong resultion #391

fabianeichinger opened this issue Sep 4, 2020 · 3 comments
Assignees
@onderceylan
Labels
bug Something isn't working released

Comments

@fabianeichinger
Copy link

Probably related to the parsing chances in #362. iPhone 6 Plus is listed as 1920x1080, which is the physical resolution of the display, but the device uses and requires a splash screen with the logical resolution 414x736@3x.
@MrRobotjs
Copy link

same issue here.

@onderceylan onderceylan self-assigned this Oct 23, 2020
@onderceylan onderceylan added the bug Something isn't working label Oct 23, 2020
@onderceylan
Copy link
Collaborator

Hi @fabianeichinger and @MrRobotjs, thanks for reporting this issue. I've just reproduced the issue myself. I will come up with a fix soon.

onderceylan added a commit that referenced this issue Oct 23, 2020
@onderceylan
fix(puppets): fix wrong splash screen resolution for Apple iPhone Plu…
afe9833 
…s devices

fix #391
onderceylan pushed a commit that referenced this issue Oct 23, 2020
@semantic-release-bot
chore(release): 3.2.3 [skip ci]
53b379c 
## [3.2.3](v3.2.2...v3.2.3) (2020-10-23)

### Bug Fixes

* **puppets:** fix wrong splash screen resolution for Apple iPhone Plus devices ([7e59b40](7e59b40)), closes [#391](#391)
* **puppets:** use emulate instead of setViewport to preserve pixel sizes ([e0a0028](e0a0028))
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 3.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@onderceylan @fabianeichinger @MrRobotjs