Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.3.0 breaks relative source file locations #45

Closed
dscheffy opened this issue Sep 26, 2019 · 3 comments · Fixed by #46
Closed

Release 1.3.0 breaks relative source file locations #45

dscheffy opened this issue Sep 26, 2019 · 3 comments · Fixed by #46
Assignees
@onderceylan
Labels
bug Something isn't working released

Comments

@dscheffy
Copy link

Describe the bug
After upgrading to 1.3.0, "npx pwa-asset-generator logo.svg" stopped working. The output files all had the typical "missing image" that you've scene in browsers before. I haven't fully diagnosed the problem, but it still works with absolute urls and with absolute paths for local files, just not relative ones.

To Reproduce
Steps to reproduce the behavior:

  1. create a new directory, copy some image to that directory
  2. run npx pwa-asset-generator <your image file>
  3. open manifest-icon-512.png

Expected behavior
manifest-icon-512.png should contain my image (but it doesn't)

System (please complete the following information):

  • OS: macOS high sierra
  • node version v11.10.0
  • npm version 6.10.3
  • cli version 1.3.0 (note, it works fine in 1.2.0)

Screenshots
manifest-icon-512
@dscheffy dscheffy added bug Something isn't working needs verification Bug needs to be verified with reproduction labels Sep 26, 2019
@onderceylan onderceylan removed the needs verification Bug needs to be verified with reproduction label Sep 26, 2019
@onderceylan
Copy link
Collaborator

Hi @dscheffy, thanks a lot for raising this issue. I was able to reproduce the same issue, I will release a fix asap.

onderceylan added a commit that referenced this issue Sep 26, 2019
@onderceylan
fix(file): fixed relative path to input file that is not resolving
3656213 
fix #45
@onderceylan onderceylan mentioned this issue Sep 26, 2019
Merged
onderceylan added a commit that referenced this issue Sep 26, 2019
@onderceylan
fix(file): fixed relative path to input file that is not resolving
19cc7c4 
fix #45
@onderceylan
Copy link
Collaborator

Just fixed the issue @dscheffy, I'll add more tests to cover issues like this in future, including visual diff on generated files. CD pipeline will publish 1.3.1 in minutes.

onderceylan pushed a commit that referenced this issue Sep 26, 2019
@semantic-release-bot
chore(release): 1.3.1 [skip ci]
062879f 
## [1.3.1](v1.3.0...v1.3.1) (2019-09-26)

### Bug Fixes

* **file:** fixed relative path to input file that is not resolving ([19cc7c4](19cc7c4)), closes [#45](#45)
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@onderceylan onderceylan self-assigned this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(file): fixed relative path to input file that is not resolving elegantapp/pwa-asset-generator
2 participants
@dscheffy @onderceylan