Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose private API and add typings.d.ts #5

Closed
onderceylan opened this issue Aug 15, 2019 · 1 comment · Fixed by #41
Closed

Expose private API and add typings.d.ts #5

onderceylan opened this issue Aug 15, 2019 · 1 comment · Fixed by #41
Assignees
@onderceylan
Labels
enhancement Code improvement, refactor feature request New feature or request released
Milestone
1.2.0

Comments

@onderceylan
Copy link
Collaborator

Currently it's not possible to use underlying API of the library other than using it via executable binary. Exposing private API that binary uses, will make it possible for users to use it in their node projects.

Exporting typings.d.ts will introduce a living documentation for the API.
@onderceylan onderceylan added the enhancement Code improvement, refactor label Aug 15, 2019
@onderceylan onderceylan added this to the 1.2.0 milestone Aug 15, 2019
@onderceylan onderceylan added the feature request New feature or request label Aug 29, 2019
@onderceylan onderceylan self-assigned this Sep 1, 2019
onderceylan added a commit that referenced this issue Sep 1, 2019
@onderceylan
feat(main): exposed private API via main.js
d3367ad 
Added generateImages function to make use of the lib functionality via node scripting

fix #5
onderceylan added a commit that referenced this issue Sep 11, 2019
@onderceylan
feat(main): refactored main and added index.d.ts
1ab1c3e 
Refactored main.js file to return saved images array, html content of  meta tags and manifest json
icons array. Added interfaces and docs via index.d.ts and updated readme.

fix #5
@onderceylan onderceylan mentioned this issue Sep 12, 2019
Merged
onderceylan added a commit that referenced this issue Sep 12, 2019
@onderceylan
feat(main): exposed private API via main.js
afce4af 
Added generateImages function to make use of the lib functionality via node scripting

fix #5
onderceylan added a commit that referenced this issue Sep 12, 2019
@onderceylan
feat(main): refactored main and added index.d.ts
72a7fe4 
Refactored main.js file to return saved images array, html content of  meta tags and manifest json
icons array. Added interfaces and docs via index.d.ts and updated readme.

fix #5
onderceylan pushed a commit that referenced this issue Sep 12, 2019
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
64ba85f 
# [1.2.0](v1.1.7...v1.2.0) (2019-09-12)

### Features

* **main:** added option to provide path prefix to generated href links ([268c671](268c671)), closes [#31](#31)
* **main:** added option to provide path prefix to generated href links ([1e18466](1e18466)), closes [#31](#31)
* **main:** exposed private API via main.js ([afce4af](afce4af)), closes [#5](#5)
* **main:** exposed private API via main.js ([d3367ad](d3367ad)), closes [#5](#5)
* **main:** refactored main and added index.d.ts ([72a7fe4](72a7fe4)), closes [#5](#5)
* **main:** refactored main and added index.d.ts ([1ab1c3e](1ab1c3e)), closes [#5](#5)
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
enhancement Code improvement, refactor feature request New feature or request released
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

1.2.0 release elegantapp/pwa-asset-generator
1 participant
@onderceylan