Improve icon assets naming and access for Android #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add updated icon token references to `CompoundIcons.kt`. - Make the code easier to measure by code coverage tools.
robintown
approved these changes
Feb 9, 2024
| @@ -35,7 +35,7 @@ export default { | |||
|
|
|||
| // Snake case and replace `icon` with `ic` as this is the convention on Android | |||
| // and on Material | |||
| const imageId = _.snakeCase(token.name.replace("icon", "ic")); | |||
| const imageId = _.snakeCase(token.name.replace("icon", "ic_compound_")); | |||
There was a problem hiding this comment.
Maybe ic_cpd_ would be a bit nicer to use? cpd is the namespace prefix that we're using for Web, though if you find ic_compound_ clearer that's completely valid
There was a problem hiding this comment.
I think ic_compound_ is easier to understand for newcomers than ic_cpd_, and it's not that much longer. Thanks for the suggestion though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ic_compound_prefix instead of justic_. This should avoid name collisions in Android, which could lead to the wrong icon being displayed if 2 icons have the same name.CompoundIcons.ktand its associated template so it's easier to measure by coverage tools. We were having issues were a large part of this file was measured as not covered by tests while the whole contents of the file were used in tests.