Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including room name in the invitation notification #4230

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Including room name in the invitation notification #4230

merged 2 commits into from
Oct 12, 2021

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Oct 12, 2021 •
edited
Loading

Fixes #582, depends on #4182 and in turn the feature/adm/notification-redesign feature branch
If the room summary is available then we add the name in the notification

BEFORE AFTER
before-room-name after-room-name

bmarty
bmarty approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small file for the changelog?

@ouchadam
Copy link
Contributor Author

ouchadam commented Oct 12, 2021 •
edited
Loading

ah 🤦

I'll remember eventually...

ecaac69

@github-actions
Copy link

github-actions bot commented Oct 12, 2021 •
edited
Loading

Unit Test Results

  42 files  ±0    42 suites  ±0   40s ⏱️ -4s
  83 tests ±0    83 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
220 runs  ±0  220 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ecaac69. ± Comparison against base commit d5e73cc.

♻️ This comment has been updated with latest results.

@bmarty bmarty merged commit 2a328c6 into feature/adm/immutable-notifiable-models Oct 12, 2021
@bmarty bmarty deleted the feature/adm/room-name-in-invitation branch October 12, 2021 18:22
This was referenced Oct 13, 2021
Merged
Closed
@ouchadam ouchadam linked an issue Oct 13, 2021 that may be closed by this pull request
Notification of invitation does not display the room name #582
Closed
@ouchadam ouchadam mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification of invitation does not display the room name
2 participants
@ouchadam @bmarty