Always showing hang up button in VOIP calls #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes the CallActivity looking stuck with no way to exit the call
ganfra
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the symptom of #4144
VectorCallActivityto always show the hang up button during the initial phases of a VOIP call (Idle, Create Offer, matching theDialingbehaviour)At least from the logs submitted in #4144 there was a native media player error which we're not able to propagate up to our
CallActivitywhich means we end up stuck in theIdlecall state. I can't seem to find a way to hook into player errors via theRemoteAudioTrack🤔The only way I've been able to reproduce this issue is by instantly recreating the call (
Activity.recreate) when it starts.