Invitation notifications are not dismissed automatically if room is joined from another client (#347) #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oined from another client (#347)
bmarty
force-pushed
the
feature/invot_notification
branch
from
ee90060 to
50a0660
Compare
BillCarsonFr
reviewed
Oct 8, 2019
Comment on lines
43
to
48
| interface PushRuleListener { | ||
| fun onMatchRule(event: Event, actions: List<Action>) | ||
| fun onRoomJoined(roomId: String) | ||
| fun onRoomLeft(roomId: String) | ||
| fun onEventRedacted(redactedEventId: String) | ||
| fun batchFinish() |
There was a problem hiding this comment.
This class is now handling more things that events that matched a push rules, could be renamed to something else? NoteworthyEventListener? ImportantEvents? or something more related to the fact that it will be used by the notification drawer? NotificationActionsListener?
There was a problem hiding this comment.
Indeed, you are right, we will rename that later
BillCarsonFr
reviewed
Oct 8, 2019
| fun dispatchRoomLeft(roomId: String) { | ||
| try { | ||
| listeners.forEach { | ||
| it.onRoomLeft(roomId) |
There was a problem hiding this comment.
should catch inside each iteration and continue?
BillCarsonFr
reviewed
Oct 8, 2019
| @@ -499,7 +507,8 @@ class NotificationDrawerManager @Inject constructor(private val context: Context | |||
| companion object { | |||
| private const val SUMMARY_NOTIFICATION_ID = 0 | |||
| private const val ROOM_MESSAGES_NOTIFICATION_ID = 1 | |||
| private const val ROOM_EVENT_NOTIFICATION_ID = 2 | |||
| private const val ROOM_INVITATION_NOTIFICATION_ID = 2 | |||
| private const val ROOM_EVENT_NOTIFICATION_ID = 3 | |||
There was a problem hiding this comment.
This event was id 2 before. Maybe add the new one as 3 (potential minor migration issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347
Also do some cleanup
Notification for an invitation is still incomplete, this is tracked here: #582
Pull Request Checklist