Feature/bma/arch fixes #7239
Merged
Feature/bma/arch fixes #7239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
requested review from
a team and
ganfra
and removed request for
a team
ganfra
reviewed
Oct 4, 2022
| /** | ||
| * Contains synchronous methods to create permalinks from the Session. | ||
| */ | ||
| class PermalinkUseCase @Inject constructor( |
There was a problem hiding this comment.
Thats a bit weird, a UseCase should only offer one method, as it's supposed to encapsulate one business rule
There was a problem hiding this comment.
Yes, this is not really a UseCase, rather a Proxy. Which name do you suggest?
|
|
||
| @Inject lateinit var sessionListener: SessionListener |
There was a problem hiding this comment.
Some of the properties were kept private on purpose, we are losing this. I don't like having @Inject in Base Activity/Fragment class
There was a problem hiding this comment.
All the injected members cannot be private. So on my side this is not much worth than before.
bmarty
force-pushed
the
feature/bma/arch_fixes
branch
from
84b6cd3 to
ff830a8
Compare
…ate.personalizationState`
…tate.personalizationState`
bmarty
force-pushed
the
feature/bma/arch_fixes
branch
from
6bca813 to
822f06f
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Fix some issues in our inject class members. There are some other issues, but I stop here for now.
Motivation and context
Avoid duplicated code, avoid injecting Session in the Views (Activity/Fragment)
Screenshots / GIFs
NA
Tests
Tested devices
Checklist