Fix breadcrumbs #7311

bmarty · 2022-10-07T09:30:13Z

Type of change

Feature
Bugfix
Technical
Other :

Content

(Not in prod so no changelog)
Fix regression from #7285.
When switching room using left panel breadcrumbs, a TimelineFragment was recreated, but because of the usage of activityViewModel, the ViewModel was not, so the current room was not changed. Using fragmentViewModel in TimelineFragment and parentFragmentViewModel in the 2 children it fixes the pb.

Motivation and context

Fix regression

Screenshots / GIFs

Tests

Switch room using breadcrumbs in a timeline.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

bmarty · 2022-10-07T09:33:28Z

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

@@ -282,8 +282,6 @@ class TimelineFragment :
    private lateinit var callActionsHandler: StartCallActionsHandler

    private val currentCallsViewPresenter = CurrentCallsViewPresenter()
-    private val isEmojiKeyboardVisible: Boolean
