Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Device management] Improve the parsing for OS of Desktop/Web sessions (PSG-823) #7323

Merged
merged 6 commits into from
Oct 13, 2022
Merged

[Device management] Improve the parsing for OS of Desktop/Web sessions (PSG-823) #7323

merged 6 commits into from
Oct 13, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Oct 10, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Improving the parsing of the user agent in the operating system fields.

Motivation and context

Closes #7321

Screenshots / GIFs

Tests

  • Enable the feature flag for new device management
  • Sign-in a Web session using the test server: synapse-prefill.lab.element.dev
  • Sign-in a mobile session
  • Go to Settings -> Security & Privacy -> Show all sessions (V2, WIP)
  • Go to the session details screen of the Web session
  • Check the operating system is correct

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review October 10, 2022 13:06
@mnaturel mnaturel requested review from a team and onurays and removed request for a team October 10, 2022 13:06
@mnaturel
Copy link
Contributor Author

We may need to remove the OS version in case of Web/Desktop sessions as it does not seem reliable.

@mnaturel
Copy link
Contributor Author

We may need to remove the OS version in case of Web/Desktop sessions as it does not seem reliable.

Parsing of the version removed: see ce161b7

@mnaturel mnaturel force-pushed the feature/mna/device-manager-extended-details branch from 8c026fd to 72f9dad Compare October 11, 2022 12:46
@mnaturel mnaturel force-pushed the feature/mna/device-manager-parsing-os branch from ce161b7 to 9b4b55c Compare October 11, 2022 12:48
onurays
onurays approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks!

@mnaturel mnaturel force-pushed the feature/mna/device-manager-extended-details branch from 72f9dad to b7190c2 Compare October 11, 2022 13:23
@mnaturel mnaturel force-pushed the feature/mna/device-manager-parsing-os branch from 9b4b55c to daa5f88 Compare October 11, 2022 13:24
@mnaturel mnaturel added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 12, 2022
Base automatically changed from feature/mna/device-manager-extended-details to develop October 12, 2022 16:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.7% 84.7% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit f9eb6a6 into develop Oct 13, 2022
@mnaturel mnaturel deleted the feature/mna/device-manager-parsing-os branch October 13, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurays onurays onurays approved these changes

Assignees
No one assigned
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Device management] Improve the parsing for OS of Desktop/Web sessions
2 participants
@mnaturel @onurays