[Device management] Hide the IP address and last activity date on current session (PSG-823)

[mnaturel]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Hiding the last seen info details on the Session Info card view when it is the current session.

Motivation and context

Closes #7324

Screenshots / GIFs

Before	After

Tests

• Enable the feature flag for new device manager
• Go to Settings -> Security & Privacy -> Show all sessions (V2, WIP)
• Check the current session info card view does not show the last seen details in the main screen and in the overview screen
• Check the last seen details info is displayed for other sessions when on session overview screen

Tested devices

• Physical
• Emulator
• OS version(s): Android 11

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[bmarty]

LGTM, thanks.

A remark on the related code:

deviceInfo.lastSeenTs
                ?.takeIf { isLastSeenDetailsVisible }
                ?.let { timestamp ->
                    views.sessionInfoLastActivityTextView.isVisible = true
                    // Some code
                } ?: run {
                    views.sessionInfoLastActivityTextView.isGone = true
                }

Is not safe to me, I would prefer to have a classical if (isLastSeenDetailsVisible) block.

The reason is that if isLastSeenDetailsVisible is true the let block will be executed, but if its last statement returns null, the run block will also be executed, and this is not what we want.

This may be updated in another PR.

[mnaturel]

LGTM, thanks.

A remark on the related code:

deviceInfo.lastSeenTs
                ?.takeIf { isLastSeenDetailsVisible }
                ?.let { timestamp ->
                    views.sessionInfoLastActivityTextView.isVisible = true
                    // Some code
                } ?: run {
                    views.sessionInfoLastActivityTextView.isGone = true
                }

Is not safe to me, I would prefer to have a classical if (isLastSeenDetailsVisible) block.

The reason is that if isLastSeenDetailsVisible is true the let block will be executed, but if its last statement returns null, the run block will also be executed, and this is not what we want.

This may be updated in another PR.

I am not sure to fully understand your point. Could you add more details about what could be wrong? What I targeted was to go into the run block if the deviceInfo.lastSeenTs is null or if isLastSeenDetailsVisible is false. I could update to a classical if/else to improve the readability but I guess it will not change the current behavior.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication