Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Device management] Add lab flag for the feature (PSG-793) #7337

Merged
merged 3 commits into from
Oct 12, 2022
Merged

[Device management] Add lab flag for the feature (PSG-793) #7337

merged 3 commits into from
Oct 12, 2022

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adding lab flag for the new session manager screens.

Motivation and context

Closes #7336

Screenshots / GIFs

Tests

  • Go to Settings -> Labs
  • Enable the new session manager flag
  • Go to Settings -> Security & Privacy -> Show all sessions
  • Check the entry leads to the new session manager screens
  • Go to Settings -> Labs
  • Disable the new session manager flag
  • Go to Settings -> Security & Privacy -> Show all sessions
  • Check the entry leads to the old session manager screens

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review October 11, 2022 15:58
@mnaturel mnaturel requested review from a team and fedrunov and removed request for a team October 11, 2022 15:58
fedrunov
fedrunov approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaturel mnaturel added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit cf9f30d into develop Oct 12, 2022
@mnaturel mnaturel deleted the feature/mna/device-manager-lab-flag branch October 12, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedrunov fedrunov fedrunov approved these changes

Assignees
No one assigned
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Device management] Add lab flag for the feature
2 participants
@mnaturel @fedrunov