Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update read marker when we go back in live #8306

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Apr 4, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Changelog already exists from #8305

Motivation and context

#8268

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from giomfo, a team and jonnyandrew and removed request for a team April 4, 2023 15:15
@yostyle yostyle marked this pull request as ready for review April 4, 2023 15:16
@yostyle yostyle requested review from a team, Florian14, bmarty and ganfra and removed request for jonnyandrew, a team, Florian14 and bmarty April 4, 2023 16:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's ok :D
The code is becoming a bit hard to follow, maybe we should handle this outside of a flow..

@yostyle yostyle merged commit 99aa949 into develop Apr 12, 2023
@yostyle yostyle deleted the yostyle/fix_unread_marker branch April 12, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants