Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tray icon in Windows forgetting your settings #1059

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix Tray icon in Windows forgetting your settings #1059

merged 1 commit into from
Jul 11, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 10, 2023 •
edited by github-actions bot
Loading

By passing guid to Tray creation in windows

Fixes #786

Here's what your changelog entry will look like:

✨ Features

@t3chguy
Fix Tray icon in Windows forgetting your settings
f8a45b0 
By passing guid to Tray creation in windows
@t3chguy t3chguy marked this pull request as ready for review July 10, 2023 16:19
@t3chguy t3chguy requested review from a team as code owners July 10, 2023 16:19
kerryarchibald
kerryarchibald approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t3chguy t3chguy merged commit 9ddd26b into develop Jul 11, 2023
@t3chguy t3chguy deleted the t3chguy/fix/d786 branch July 11, 2023 16:00
@t3chguy t3chguy mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from element-hq/element-web-team

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installing the latest electron build in windows overwrites the tray icon display preferences
2 participants
@t3chguy @kerryarchibald