Crypto: Device deduplication method sometimes crashes

[manuroe]

A migration script had been added to version 0.7.11 to fix duplicated devices (#2132) but that script can crash, which avoids the bug fix effect.

[aaronraimist]

When you get the chance can you send me the logs from my crashes? @aaron:raim.ist

I can't reproduce my crashes in the simulator.

[manuroe]

The reason you cannot reproduce it on your simulator is that the crypto store is not synchronised across devices.
The issue is located only on your device.

[manuroe]

It seems that cleanDuplicatedDevicesInRealm should be rewritten to avoid the Object has been deleted or invalidated. exception from realm.

[manuroe]

Reopened to not forget to remove the patch at matrix-org/matrix-ios-sdk#620

[aaronraimist]

0.7.12 didn't crash so that's good but E2E encryption isn't fully fixed.

All of my devices that I previously verified show up as verified now but I still can’t verify new devices or unverify exiting devices.

[manuroe]

0.7.12 didn't crash so that's good but E2E encryption isn't fully fixed.

This is normal. The bug was in the Realm DB migration script from 0.7.10 to 0.7.11.

The final fix for the issue needs a new DB version. But I do not want to change the DB version on TestFlight betas because if people comes back to the app store version, their e2e keys will be trashed because Realm does not support backward compatibility on DB version :/.

[manuroe]

DB migration re-enabled in matrix-org/matrix-ios-sdk#630